Hatch pattern tool SOLVED

[Mathew]

OK, that screen shot helps: Your version of PDF XChange (7.0) is quite old and it uses an older version of javascript that doesn't seem to support a lot of the language that's used in this script (arrow functions, shorter method definitions, classes...). It's throwing a syntax error when it initializes (see the second line in the javascript console output). It may be possible to rewrite the script to work with the older versions of javascript, but it would be a lot easier to upgrade to the latest version of PXE...

[Daniel - PDF-XChange]

Hello, Mathew

Indeed, updating would be the best solution. There have also been a number of advancements to supported definitions since V7, (I do not believe we supported most of the "security" flatted functions back then either). As such, I am unsure if it would be possible to port this back that far, unless you managed to create the entire script inside of the JS file itself, without using the external file you have supplied here.

I hope ghaithhumaimidi choses to update the software here to benefit not only from your scripts, but also from the numerous improvements we have made to the software in the 5+ years since the build they are running.

Kind regards,

[Mathew]

I just realized: Because of a bug in the gestures property of ink annotations that was fixed in build 367, this tool will not work well in versions before that, even if it was rewritten to deal with the language issues. I'll add a note about that on the first post.

@ghaithhumaimidi Unlike other software, PDF XChange is constantly improving and adding new features. Keeping up-to-date is 100% worth it.

[Daniel - PDF-XChange]

[Mathew]

This is a minor update to fix dialog recursion error on coordinates (happens if you change the base coordinates), make displayed strings localizable with __() using 'hatchTool' domain, minor code cleanup. I've included a translation file 'translationData.hatchTool.json' and the 1ang.js script as well as IECpatterns.pat. Also updated in the first post.

hatch tool v2.1.zip

If someone has the interest in adding translations, the strings are in the file translationData.hatchTool.json and pasted below:

Code: Select all

{
"": {
     "Hatch": "",
     "Add hatch pattern…": "",
     "Hatch…": "",
     "No hatch patterns loaded! Check filenames: %1": "",
     "Other - Enter:": "",
     "None - draw through interior shapes": "",
     "Outer - skip all interior shapes": "",
     "Alternate - alternate across nested shapes": "",
     "Hatch Annotations": "",
     "Hatch Parameters (fixed)": "",
     "Hatch Pattern:": "",
     "Rotation:": "",
     "Scale:": "",
     "Island Detection:": "",
     "Origin Offset x,y:": "",
     "Corners:": "",
     "Hatch Properties (editable)": "",
     "Hatch Color": "",
     "Select Color:": "",
     "The first element in the comma separated list is a string denoting the color space type. The subsequent elements are numbers that range between zero and 255 inclusive. For example, the color red can be represented as [RGB, 255, 0, 0]. \nColor Space options are: \nG (Gray - single value 0 is black), RGB (3 values), CMYK (4 values).": "",
     "Hatch Line Width:": "",
     "Preview": "",
     "Nothing selected": "",
     "No pattern drawn: Too large scale?": "",
     "Yes to accept hatch, or No to return to dialog.": "",
     "Accept Hatch?": ""
}
}

[Daniel - PDF-XChange]

[chitown4c]

Hello,

Thank you for this script. Works great.

[jfkwhat]

Hi

Great feature - I have often found myself wishing I had this in PDF XChange so thanks for creating it and sharing it. Having trouble with colours on mine though, I get a recursion error.

Code: Select all

App:Init:1116: InternalError: too much recursion

PDF XChange Version: 10.3.1.387

Great tool overall, very glad to have this feature.

John

[Ateya]

Thank you for this great tool, it really helped us alot

Currently i am facing an issue while changing the color

If I am trying to open the drop down menu it disappears quickly as if I have double clicked it so I am unable to change the color selection and black keeps selected, if I managed to open the drop menu by any means and select the required color no hatch is implemented and this error appears in js console

Code: Select all

"App:Init:1116: InternalError: too much recursion"

So the case is, whwnever I touch the color selection menu either I chnge the color or not I get the above error.

to be able to use hatch, I have to use the default selected color and then chage the color from comment properties tab

[Stefan - PDF-XChange]

Hello Ateya,

Welcome to our forums! Is the jfkwhat post above yours also done by yourself? As they seem to be reporting the same error with colours! I am sure Mathew who wrote that script will comment soon on the colours issue. And in the mean time - if the above two posts are duplicate - shall we remove one of them?

Kind regards,
Stefan

[Ateya]

Hello Ateya,

Welcome to our forums! Is the jfkwhat post above yours also done by yourself? As they seem to be reporting the same error with colours! I am sure Mathew who wrote that script will comment soon on the colours issue. And in the mean time - if the above two posts are duplicate - shall we remove one of them?

Kind regards,
Stefan

Thank you for your prompot response.

One more thing to suggest, I am trying go add the tool in the home toolbar next to comments, So I have all comment tools in one place, but modifying the tool location is not allowed.

is there any way to move it ?

[Stefan - PDF-XChange]

Hello Ateya,

Unfortunately no - custom tools that are created by JS code stay in their own "Add on Tools" toolbar and it's not possible to move them to other places, sorry!

Kind regards,
Stefan

[Ateya]

Hello Ateya,

Unfortunately no - custom tools that are created by JS code stay in their own "Add on Tools" toolbar and it's not possible to move them to other places, sorry!

Kind regards,
Stefan

This might be true, but I think I had this as a bug.
before the color problem appears I had it in home tab

but when the colo problem happens I thought it is related to my windows so I reset the setting to defaults removing all 3rd party apps.
I installed it again now I am not able to move it to home tab.

[Stefan - PDF-XChange]

Hello Ateya,

Yes - custom buttons created by JS can not be moved. Maybe you had another tool in your home tab in the past!?

Kind regards,
Stefan

[Mathew]

@Ateya thank you for the bug report. I think I've fixed the color selection problem here (I'll update the first post too):

I also made a couple of other changes: I added a sub-menu on the "File" menu called "Add-in tools" (because that's the only place the ribbon currently allows one to add menu items. I think Tracker has something "in the works" that would allow one to add buttons to the other ribbons but probably not soon.) And I used an online translator to add translation strings for German (picked randomly just as an experiment -- there are probably some gaffes in there but I don't speak German ).

hatch tool v2.1.1.zip

[Ateya]

@Ateya thank you for the bug report. I think I've fixed the color selection problem here (I'll update the first post too):

I also made a couple of other changes: I added a sub-menu on the "File" menu called "Add-in tools" (because that's the only place the ribbon currently allows one to add menu items. I think Tracker has something "in the works" that would allow one to add buttons to the other ribbons but probably not soon.) And I used an online translator to add translation strings for German (picked randomly just as an experiment) -- there are probably some gaffes in there but I don't speak German

hatch tool v2.1.1.zip

Thank you for your prompot action, I wish if I have put this comment before resetting my PC and losing the advantage if having hatch option in the home toolbar

Regarding the German, Depite I am working for a german company, badly I do not know German.

Keep going it is a very useful tool for every engineer, and PDF XCHANGE is the most user friendly pdf reader.

[Mathew]

This might be true, but I think I had this as a bug.
before the color problem appears I had it in home tab

This will be possible one day - there's a current feature request that Tracker have accepted, but don't hold your breath. Currently it can show on the "Add-on Tools" as well as a menu item under "File" in the Ribbon UI. There is a temporary tweak one can do, but it doesn't last when the application restarts. The classic UI is a bit more customizable, but it seems I'm the only one using that these days

[Daniel - PDF-XChange]

Hello, Mathew

From what I can find in ticket RT#6655: FR: JS add-tool to other ribbon tabs, this is on its way, and it is likely the solution will be to add special ribbon UI relevant parameters, which other apps reading the JS would essentially ignore. It seems likely that we will get items like "cParentRUI" and "nPosRUI" (names are still a WiP, but when I hear more from the Devs I will let you know).

I don't have confirmation of when this is coming, so I cannot promise a timeline just yet.

Kind regards,

[Ateya]

This might be true, but I think I had this as a bug.
before the color problem appears I had it in home tab

This will be possible one day - there's a current feature request that Tracker have accepted, but don't hold your breath. Currently it can show on the "Add-on Tools" as well as a menu item under "File" in the Ribbon UI. There is a temporary tweak one can do, but it doesn't last when the application restarts. The classic UI is a bit more customizable, but it seems I'm the only one using that these days

Good to know, Classic UI is great but Microsoft took the lead and changed how softwares should be, since that moment we are used to any UI similar to ms office

[Ateya]

Hello, Mathew

From what I can find in ticket RT#6655: FR: JS add-tool to other ribbon tabs, this is on its way, and it is likely the solution will be to add special ribbon UI relevant parameters, which other apps reading the JS would essentially ignore. It seems likely that we will get items like "cParentRUI" and "nPosRUI" (names are still a WiP, but when I hear more from the Devs I will let you know).

I don't have confirmation of when this is coming, so I cannot promise a timeline just yet.

Kind regards,

We need to make a ticket to add comment grouping and ungrouping in the new revisions

[Daniel - PDF-XChange]

Hello, Ateya

Don't worry, that one is already on its way, but may still be a bit of a ways out. I cannot promise when, but I have already seen a very early implementation of comment grouping working in the Editor with a Dev build. It definitely has a few kinks we need to iron out before its ready to go live.

Kind regards,

[jfkwhat]

Thanks Matthew

That seemed to fix the colour issue at my end!

Great feature! Thank you for sharing it and the prompt updates!


John

[Stefan - PDF-XChange]

[bertrand.savarit]

Hello everyone,
it seems that I missed something during the installation of the plugin. When I run it on a hatch, the pop-up window appears, but all the fields are empty... See the screenshot below. Could you help me?"

image.png

[Mathew]

When I run it on a hatch, the pop-up window appears, but all the fields are empty.

What version of PDF XChange are you using? Also, are any errors showing up in the javascript console (CTRL-J)?

[Daniel - PDF-XChange]

Hello, Mathew

This is just a little bump on this topic (and a post from one of us to "close" it for now incase they do not come back to answer your question).

Kind regards,

[Ateya]

We have recieved an update, have they enabled us to add user add-on in the home toolbar so the code could be updated to be in the home tab ?

[bertrand.savarit]

What version of PDF XChange are you using? Also, are any errors showing up in the javascript console (CTRL-J)?

I'm using Version 10.2.1 build 385

I have this message in the javascript console :
" App:Init TypeError: arry is undefined "

[Paul - PDF-XChange]

Hi, bertrand.savarit

10.4.0.388 is current. Please try updating. even if it doesn't resolve the issue directly, it provides a baseline that makes it better to help you.

I am keen to hear how it goes.

[Mathew]

I have this message in the javascript console :
" App:Init TypeError: arry is undefined "

Based on the line numbering, I'm guessing it's a previous version of the script. There were some problems with the dialog that I fixed in the most recent version of the script (v2.1.1) here:
viewtopic.php?p=169623#p169623

Let me know if that doesn't fix it.

[Mathew]

We have recieved an update, have they enabled us to add user add-on in the home toolbar so the code could be updated to be in the home tab ?

Yep, but I've not had time to do it yet. Will do, though.

[Paul - PDF-XChange]

You know Mathew your contributions here are so very very much appreciated, please do not feel any pressure.

We are all better off having you here. Your contributions are worth any wait IMHO.

[Ateya]

We greatly appreciate your exceptional work.
We eagerly anticipate your progress updates, much as we do with software release announcements.

We have recieved an update, have they enabled us to add user add-on in the home toolbar so the code could be updated to be in the home tab ?

Yep, but I've not had time to do it yet. Will do, though.

[Stefan - PDF-XChange]

[bertrand.savarit]

Based on the line numbering, I'm guessing it's a previous version of the script. There were some problems with the dialog that I fixed in the most recent version of the script (v2.1.1) here:
viewtopic.php?p=169623#p169623

Let me know if that doesn't fix it.

It is now working with this version of the script!
Thanks a lot !

[Stefan - PDF-XChange]

[Mathew]

I've made an updated version attached below. This is the first time I've worked with the new options for placing items in the ribbon menu - they're quite extensive! I put it in the home toolbar to the right of the markup tools.

I also changed how the color options work by moving it to a separate file so I can also access it from other scripts (change colors).

Still currently only the machine translated German language. I'm trying to think of a way to make it easier to generate the translation files.

Let me know if I've messed anything up. I'll wait to update at the main post in case something's wrong.

hatch tool v2.2.zip

Changes in v2.2:

• Display on Home ribbon
• Change preferences save function in anticipation of adding option to pick locations of hatch data files
• Moved color utils to external file
• Add hexadecimal option and menu to edit saved colors
• Change how color names are auto-generated (tries to pick two nearest colors)

[Daniel - PDF-XChange]

Hello, Mathew

Thank you very much for this, if you have any feedback about the new options, please do let us know, I can pass them along to the Dev team.

Kind regards,

[Ateya]

I've made an updated version attached below. This is the first time I've worked with the new options for placing items in the ribbon menu - they're quite extensive! I put it in the home toolbar to the right of the markup tools.

I also changed how the color options work by moving it to a separate file so I can also access it from other scripts (change colors).

Still currently only the machine translated German language. I'm trying to think of a way to make it easier to generate the translation files.

Let me know if I've messed anything up. I'll wait to update at the main post in case something's wrong.
hatch tool v2.2.zip

Changes in v2.2:

• Display on Home ribbon
• Change preferences save function in anticipation of adding option to pick locations of hatch data files
• Moved color utils to external file
• Add hexadecimal option and menu to edit saved colors
• Change how color names are auto-generated (tries to pick two nearest colors)

I am using version 10.4.4 build 392, the hatch faild to load and the javascript shows the following error "App:Init:301: TypeError: colStr is undefined"
When using polygon for hatch I am facing the following error "App:Init TypeError: shapes[0] is undefined"

image.png

[Mathew]

I am using version 10.4.4 build 392, the hatch faild to load and the javascript shows the following error "App:Init:301: TypeError: colStr is undefined"

Thanks @Ateya - I think I found the bug and squashed it. Revised version 2.2.1 below (also updated in the main post above):

hatch tool v2.2.1.zip

Changes in this revision:

• move icon to comment tools block on ribbon
• fix error in xutil.colFromStr() when undefined given as color (ie for new installation)
• don't automatically check 'save' box for current color when saving colors

[Stefan - PDF-XChange]

Hello Mathew,

Thanks for that update! Much appreciated!

Kind regards,
Stefan

[Mathew]

A slight improvement (allows to hatch in pencil annotations) and bug fix.

hatch tool v2.3.zip

image.png

Changes

• fix bug when lines that are too short or zero length (ignores length^2 less than 0.0001 pt),
• add ink annotation gestures but ignore curvature

[ghaithhumaimidi]

Happy to report that after upgrading to the latest version (Version: 10.4.4, build 392), the hatch pattern tool is working beautifully!
Thanks a million!!

[Stefan - PDF-XChange]

[glardner]

I just wish to chip in to say "Thank you" to Matthew for this wonderful add-on. I have only recently discovered it; it is a great time-saver.

Gerard

[Mathew]

[Jordan - PDF XChange]

[jtabirao]

Hello Mathew,

Is there a chance or a way that this Hatch pattern tool would work on V7 or V8 their build is between 328 to 335?

Thanks

[Mathew]

Hello Mathew,
Is there a chance or a way that this Hatch pattern tool would work on V7 or V8 their build is between 328 to 335?
Thanks

It depends on the javascript version in those builds. Babel may be able to convert the javascript -- but probably it will require some manual work on your part too; and even then, it may not work as well as you hope due to some PXCE bugs that were fixed in build 367. This was discussed earlier viewtopic.php?p=181039#p181039 Lots of good stuff in the more recent versions of PXCE - if there's any way you can figure out to upgrade, I recommend it - a much better use of your effort than trying to rewrite this tool, IMO.

[Daniel - PDF-XChange]